----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51386/#review146809 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Aug. 24, 2016, 8:21 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51386/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 8:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-18255 > https://issues.apache.org/jira/browse/AMBARI-18255 > > > Repository: ambari > > > Description > ------- > > The software is allowing duplicate records into the host_version table. This > should be constrained in the db. > > This will only get pushed to trunk, not a 2.4 branch. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > f7644d3 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 6be4b50 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > e1b9368 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > ebfb267 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > PRE-CREATION > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c20cd1b > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f30b2eb > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50feb87 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0843616 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 43bdef9 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1ef4ae1 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql babcb6d > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > d8e1576 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/51386/diff/ > > > Testing > ------- > > Tests run: 4609, Failures: 0, Errors: 0, Skipped: 34 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:25:27.562s > [INFO] Finished at: Wed Aug 24 15:59:06 EDT 2016 > [INFO] Final Memory: 34M/759M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
