-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51356/#review146871
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On Aug. 24, 2016, 1 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51356/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 1 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18247
>     https://issues.apache.org/jira/browse/AMBARI-18247
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Dependent configs dialog shows recommended values for capacity scheduler 
> which is incomprehensible to read. It will be good to breakdown the specific 
> changes into separate rows.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mixins/common/configs/config_recommendations.js 398cf55 
>   ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs 
> 0fe073c 
>   ambari-web/app/utils/config.js 7e1f5b8 
>   ambari-web/config.coffee 4a29e73 
>   ambari-web/karma.conf.js 013cc2e 
>   ambari-web/test/mixins/common/configs/config_recommendations_test.js 
> 3f7d6b1 
>   ambari-web/vendor/scripts/difflib.js PRE-CREATION 
>   ambari-web/vendor/scripts/diffview.js PRE-CREATION 
>   ambari-web/vendor/styles/diffview.css PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51356/diff/
> 
> 
> Testing
> -------
> 
> Modified unit test.
> Local ambari-web test passed.
> 29244 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to