----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51458/#review146967 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Aug. 26, 2016, 2:19 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51458/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 2:19 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-18264 > https://issues.apache.org/jira/browse/AMBARI-18264 > > > Repository: ambari > > > Description > ------- > > serverConfiguration.py in ambari_server Python code prints logs via both the > plain print() and the info/warning/err level logger. All the prints should be > corrected with the proper logging level indicator, strings should also be > formatted instead of concated. > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/serverConfiguration.py 65bf55c > > Diff: https://reviews.apache.org/r/51458/diff/ > > > Testing > ------- > > installed Ambari 2.1 cluster with HDP, run ambari upgrade , check the command > line print out. > > > Thanks, > > Di Li > >
