> On Aug. 26, 2016, 1:22 p.m., Robert Nettleton wrote: > > Thanks for contributing this patch. > > > > The patch looks fine to me. > > > > The main problem for Blueprints in this case is that the stack definitions > > do not provide for specifying dependencies that are conditional. In this > > case, it would be nice to have the stack definitions model this type of > > "optional dependency", for component dependencies that only exist in > > NameNode HA mode. There are other cases where this would be helpful as > > well. > > > > The current patch is fine, and fits in well with the kind of validation > > Blueprints already does in code. In the future, we might want to consider > > updating the stacks to handle this type of dependency, so that future > > versions of Ambari could handle this in the stack definitions.
Thanks Robert. - Amruta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51441/#review146950 ----------------------------------------------------------- On Aug. 25, 2016, 11:29 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51441/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 11:29 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-18179 > https://issues.apache.org/jira/browse/AMBARI-18179 > > > Repository: ambari > > > Description > ------- > > The patch validates component dependency for NN when HA is enabled cluster. > Observed that when a blueprint is deployed to create NN HA enabled cluster > without ZKFC compoent, installation goes through but HDFS service check > fails, giving error for missing ZKFC component. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > dbf736f > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java > a5acc42 > > Diff: https://reviews.apache.org/r/51441/diff/ > > > Testing > ------- > > Added and modified test cases. Performed manual testing and blueprint was not > accepted when ZKFC was missing. > > > Thanks, > > Amruta Borkar > >
