----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51466/#review147024 -----------------------------------------------------------
Fix it, then Ship it! ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java (line 134) <https://reviews.apache.org/r/51466/#comment213996> 0 should be a valud default value. ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java (line 167) <https://reviews.apache.org/r/51466/#comment213998> Why not call put instead of creating a Map? ambari-server/src/main/resources/ganglia_properties.json (line 46) <https://reviews.apache.org/r/51466/#comment214000> This change would mean API is changing and Ambari widget definition would need to change. Why not preserve the same key ? - Sid Wagle On Aug. 26, 2016, 9:15 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51466/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 9:15 p.m.) > > > Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-18154 > https://issues.apache.org/jira/browse/AMBARI-18154 > > > Repository: ambari > > > Description > ------- > > PROBLEM > Under Ambari Dashboard -> Cluster metrics. It has been noticed that the > metrics Nodes_avg and CPUs_avg are showing the same data. > > BUG > They are requesting the same metric (cpu_num) from AMS. > > FIX > Track live_hosts metric in AMS - Number of hosts sending metrics to AMS in > the last 2 minutes. Change dashboard widget to show the new metric. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java > 1676867 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java > b992d60 > ambari-server/src/main/resources/ganglia_properties.json 5632bc0 > ambari-server/src/main/resources/sqlserver_properties.json 10756f2 > ambari-web/app/utils/ajax/ajax.js af3a9e2 > > contrib/ambari-scom/ambari-scom-server/src/main/resources/sqlserver_properties.json > 10756f2 > > Diff: https://reviews.apache.org/r/51466/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
