> On Aug. 31, 2016, 8:43 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js, line 
> > 270
> > <https://reviews.apache.org/r/51452/diff/1/?file=1486644#file1486644line270>
> >
> >     - Why are we having this controller variable
> >     - Indentation can be made better.

The controller variable would be used to call an api in controller. This code 
is incomplete. Next patch should have whole code.
Indentation - How can we make it better?


> On Aug. 31, 2016, 8:43 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js, line 
> > 300
> > <https://reviews.apache.org/r/51452/diff/1/?file=1486644#file1486644line300>
> >
> >     Guess it might be better to put all finds into a promise array.

Will try with promise array!


- Akhil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51452/#review147417
-----------------------------------------------------------


On Aug. 26, 2016, 7:09 a.m., Akhil PB wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51452/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 7:09 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18261
>     https://issues.apache.org/jira/browse/AMBARI-18261
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Showing warning icons to refresh or restart capsched once after configs are 
> saved
> Bug fixes
> 
> 
> Diffs
> -----
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 
> f300b5b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b86719f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js
>  ed22c2b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js
>  b244097 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  89e7cac 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  8118805 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  c15f100 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js
>  ea5262d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  edd8a3b 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  dd46b2c 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  a68a2aa 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  6638b4c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> acf6465 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> 0b13a8a 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  195b55d 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  a9ef778 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  1f6fbda 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  9073910 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  73a9e21 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  7b25af3 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  262f380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  1bc3380 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  7649512 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs
>  a7901b8 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  fa35518 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  9c3ffd0 
> 
> Diff: https://reviews.apache.org/r/51452/diff/
> 
> 
> Testing
> -------
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Reply via email to