----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51597/#review147660 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java (lines 472 - 477) <https://reviews.apache.org/r/51597/#comment214881> I'm curious if we should also try to catch this in the ServiceComponentHost; don't let it's state move to STARTED if it knows it's a client. - Jonathan Hurley On Sept. 2, 2016, 8:11 a.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51597/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 8:11 a.m.) > > > Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-18302 > https://issues.apache.org/jira/browse/AMBARI-18302 > > > Repository: ambari > > > Description > ------- > > Configuration changes are propagated to host components by issuing a restart > of the affected components. > In case of master components this action will start the affected components > (regardless it is in INSTALLED or STARTED state) and the desired state will > be set to STARTED. > In Ambari client components are always expected to be in INSTALLED state. > However upon configuration changes, the desired state of these components are > also set to STARTED. This may be misleading for ambari API users that > determine component states by checking the desired state and actual state. > (The actual state in case of client components will always be INSTALLED) > This issue addresses this problem by not updating the desired state when > client components are restarted. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8c8ae10 > > Diff: https://reviews.apache.org/r/51597/diff/ > > > Testing > ------- > > Unit tests running. > > > Thanks, > > Laszlo Puskas > >
