-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51604/#review147668
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Sept. 2, 2016, 3:26 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51604/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 3:26 p.m.)
> 
> 
> Review request for Ambari, Jesus Alvarez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-11639
>     https://issues.apache.org/jira/browse/AMBARI-11639
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When building a custom version of ADMIN VIEW jar with new version such as 
> "2.1.0_custom", the UI returns a 404 message upon redirect.
> 
> Upon loading ambari-server (http://node1.bigdata:8080) for the first time, 
> the URL is redirected to:
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0_custom/INSTANCE/# , which 
> returns a 404 missing page.
> 
> If the URL is manually changed to 
> http://node1.bigdata:8080/views/ADMIN_VIEW/2.1.0/INSTANCE/# , the UI loads – 
> though links in ambari UI remain broken.
> 
> This appears to be caused by
> latestVersion = sortedMappedVersions[sortedMappedVersions.length-1];
> and ambari.service.load_server_version ; each parsing version string 
> differently.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/router.js d367ce3 
>   ambari-web/app/views/main/admin/stack_upgrade/versions_view.js 59baf07 
>   ambari-web/test/router_test.js e17c9e2 
>   ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b7df818 
> 
> Diff: https://reviews.apache.org/r/51604/diff/
> 
> 
> Testing
> -------
> 
> existing unit test
> added new unit test
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to