-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51691/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
Bugs: AMBARI-18331
https://issues.apache.org/jira/browse/AMBARI-18331
Repository: ambari
Description
-------
In AMBARI-16913 we revised the JMX retrieval method to maintain an internal
state of JMX metrics, with the retrieval taking place out of band of the actual
jetty query requiring the metric. However, each query will still generate a
refresh request to the metric, regardless of it's current state.
Recommend setting a TTL on a given metric such as 5 seconds, and only generate
a new request for the metric if a TTL has expired, to avoid large amounts of
repeat metrics collections in short windows.
Diffs
-----
ambari-server/docs/configuration/index.md 18234d0
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
db1b81e
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
7665d7f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
cbe827a
ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java
fa36905
ambari-server/src/test/java/org/apache/ambari/server/state/services/MetricsRetrievalServiceTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/51691/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
