-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51537/#review148073
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Sept. 7, 2016, 5:45 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51537/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 5:45 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18279
>     https://issues.apache.org/jira/browse/AMBARI-18279
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Instead of using jinja templates use the PropetiesFile command in 
> resource_management.libraries.resources.properties_file to generate the 
> property files, thus prevent enumerating all the non-custom properties in 
> params.py
> 
> Also fixed a bug: the default values for the audit logs solr znodes and 
> quorum were mixed up.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  56ff2d1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5c3954f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  d3851d3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  aa89609 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  86f0be4 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  1bcee2d 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> f4dbd63 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 5a2e6e8 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json a016ce0 
>   ambari-web/app/data/HDP2/site_properties.js 1fad1d6 
> 
> Diff: https://reviews.apache.org/r/51537/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to