-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51201/#review148074
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On Aug. 18, 2016, 10:37 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51201/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2016, 10:37 a.m.)
> 
> 
> Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18196
>     https://issues.apache.org/jira/browse/AMBARI-18196
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - generate rest api doc with swagger
> - changed the root endpoint mapping form /service/* to /api/v1
> - currently I using implicit params for the endpoint, but the after i will 
> rework the rest API, i expect to use objects instead of that (if swagger 
> supports not primitive types for queries) ... there i will update the 
> endpoints that ambari uses as well
> - i created a lot of empty descriptions, we will fill that later (im not sure 
> about: what some query parameters do or do we need them anyway, etc.)
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-it/pom.xml 075a22a 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 7a46fe5 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  819d3b9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
>  6d18b4a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
>  cb87f6f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/LogFileREST.java
>  ef1bb8f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/PublicREST.java
>  7977703 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/UserConfigREST.java
>  40b215c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
>  5e24d88 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/security-applicationContext.xml
>  96852b5 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/WEB-INF/web.xml 
> dc8519a 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/login.html ff546ef 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/App.js 
> ef9b662 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Globals.js
>  212846b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditAggregatedView.js
>  acca51c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  6932355 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/helpers/Helpers.js
>  2117aa3 
> 
> Diff: https://reviews.apache.org/r/51201/diff/
> 
> 
> Testing
> -------
> 
> testing done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to