-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51678/
-----------------------------------------------------------

(Updated Sept. 7, 2016, 9:02 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sid Wagle.


Changes
-------

I have incorporated reviews comments and attached the new code diff again.


Bugs: AMBARI-18290
    https://issues.apache.org/jira/browse/AMBARI-18290


Repository: ambari


Description
-------

If HTTPS is enabled for HBase, Ambari still tries to communicate on HTTP port 
to fetch JMX properties. because of that Ambari shows incorrect Active/Standby 
node information.

Have made code changes to read the "hbase.http.policy" property and then decide 
the protocol.

Note: I have not made any changes to Ambari Web. If HTTPS is enabled for HBase 
then all quick links should be opened on HTTPS. Currently Ambari checks  
"dfs.http.policy" HDFS/Hadoop property and decide whether for all the quick 
links.  it does not check HBase "hbase.http.policy" property to decide. am 
leaving this functionality as it is.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 066d5c4 

Diff: https://reviews.apache.org/r/51678/diff/


Testing
-------

Test cases executed
------------------
1. Install Ambari2.4, install HBase service, in summary it should show "Active 
HBase Master"  properly
2. Install Ambari2.4, install HBase service and enable HTTPS, in summary it 
should show "Active HBase Master"  properly
3. Install Ambari2.4, install HBase service and add one more HBase master. it 
should show one node as active and other is standby
4. Install Ambari2.4, install HBase service and add one more HBase master and 
enable HTTPS. it should show one node as active and other is standby


Thanks,

Amarnath reddy pappu

Reply via email to