-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51708/#review148198
-----------------------------------------------------------


Ship it!




The patch looks fine to me.

Thanks for catching and fixing this bug.

- Robert Nettleton


On Sept. 7, 2016, 10:03 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51708/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 10:03 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18333
>     https://issues.apache.org/jira/browse/AMBARI-18333
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> While validating host groups in blueprint for component dependency, code 
> should check if a dependency component is present in the host group component 
> list rather than the component on whose dependency list it is iterating.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  398772e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  ea6bee3 
> 
> Diff: https://reviews.apache.org/r/51708/diff/
> 
> 
> Testing
> -------
> 
> Added Test cases, performed manual testing
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Reply via email to