----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51711/#review148216 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java (line 474) <https://reviews.apache.org/r/51711/#comment215666> We should rename this to something like, HostStatusHelper. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MetricsHostUtil.java (line 42) <https://reviews.apache.org/r/51711/#comment215669> formatting. ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java (line 53) <https://reviews.apache.org/r/51711/#comment215678> This should be configurable if its there. 5 minutes is aggressive considering we do not need to distributed the reads as number of readers are exponentially less than writes. ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java (line 71) <https://reviews.apache.org/r/51711/#comment215676> Instead change to java.util.concurrent ds like CopyOnWrite to avoid locking when no needed. ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java (line 142) <https://reviews.apache.org/r/51711/#comment215675> Calling mutation on the ds from non-synchronized method. ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java (line 63) <https://reviews.apache.org/r/51711/#comment215681> If this is an injected field why is constructor initializing ? - Sid Wagle On Sept. 7, 2016, 10:27 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51711/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 10:27 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17458 > https://issues.apache.org/jira/browse/AMBARI-17458 > > > Repository: ambari > > > Description > ------- > > Support Multiple collectors in Ambari Server, managed through a separate > MetricsHAManager module. Round robin scheduling with 5mins time slice is used > for toggling between available collectors. Ambari event framework is used to > notify the MetricsHAManager about a down collector. > > This patch also fixes the bug in reporting AMS components' process status. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 9da6fd4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > b1fd592 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 75d8449 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MetricsHostUtil.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAClusterState.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > 9e81df4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java > 3688742 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java > 1df0f6a > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java > b5fe05e > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 912c441 > > ambari-server/src/main/java/org/apache/ambari/server/events/MetricsCollectorHostDownEvent.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py > 2c7119b > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > 747a687 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py > d53c1fc > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > 14af3ad > > Diff: https://reviews.apache.org/r/51711/diff/ > > > Testing > ------- > > Manually tested. > Unit tests pending. > > > Thanks, > > Aravindan Vijayan > >
