-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51743/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Bugs: AMBARI-18345
https://issues.apache.org/jira/browse/AMBARI-18345
Repository: ambari
Description
-------
'Stack advisor' validation code reports error while trying to access
"yarn.nodemanager.resource.memory-mb" config.
**Reason:**
- Fn. 'validateHiveInteractiveSiteConfigurations' tried to query for config
'yarn.nodemanager.resource.memory-mb'. The config may not be passed in
services[configurations], depending on which action triggered the validation.
- Fn. 'validateHiveInteractiveSiteConfigurations' was broken because it was
trying to query config 'yarn.nodemanager.resource.memory-mb', without checking
whether HSI is installed or not.
**Fix:**
- Moved the ''yarn.nodemanager.resource.memory-mb'' config query code once we
have checked the presence of HSI.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
e4b82a1
Diff: https://reviews.apache.org/r/51743/diff/
Testing
-------
- Tested on the live cluster and validation code passes/works now.
- Python UT passes.
----------------------------------------------------------------------
Ran 267 tests in 7.291s
OK
----------------------------------------------------------------------
Total run:1124
Total errors:0
Total failures:0
OK
- Jenkins: pending.
Thanks,
Swapan Shridhar
