----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51698/#review148252 -----------------------------------------------------------
ambari-server/conf/unix/metrics.properties (line 28) <https://reviews.apache.org/r/51698/#comment215720> Can you uppercase DB instead of Db for consistency. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (line 888) <https://reviews.apache.org/r/51698/#comment215721> Why? If MetricsServiceImpl is injected it can get this from guice instead of setter method. ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java (line 53) <https://reviews.apache.org/r/51698/#comment215722> Sources should not get a passed down serverConfig if what it realy needs is just hostname property. - Sid Wagle On Sept. 8, 2016, 8:25 p.m., Li-Wei Tseng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51698/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 8:25 p.m.) > > > Review request for Ambari and Aravindan Vijayan. > > > Bugs: AMBARI-17589 > https://issues.apache.org/jira/browse/AMBARI-17589 > > > Repository: ambari > > > Description > ------- > > Added Database metrics generated by Eclipselink Performance Profiler > > > Diffs > ----- > > ambari-server/conf/unix/metrics.properties 5f01e39 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > d20b1d7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > bd34c25 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java > 809176be > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java > 23845c9 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java > cf10408 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java > 58e2045 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java > 4618618 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java > 705971f > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java > a04ca43 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java > 1645ebf > > ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java > 6717e01 > ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 > > ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/51698/diff/ > > > Testing > ------- > > Unit test for emit metrics to AMS > > > Thanks, > > Li-Wei Tseng > >