----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51747/#review148265 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Sept. 8, 2016, 9:11 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51747/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 9:11 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-18324 > https://issues.apache.org/jira/browse/AMBARI-18324 > > > Repository: ambari > > > Description > ------- > > Externalize skip repo url check to ambari.properties instead of hardcoding it > in Ambari Java code, so that users can define what repo ids to skip repo urls > validation when adding repos for the given stack > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 0690ca8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 8d6e6e2 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > f9b76f8 > > Diff: https://reviews.apache.org/r/51747/diff/ > > > Testing > ------- > > existing unit tests > added new unit tests > Patched a trunk cluster with the code change, make sure the properties is not > in the ambari.properties file, verify I can add repos (meaning the default > value kicked in). add the properties with a non-default value, verify I can't > add repos. > > > Thanks, > > Di Li > >
