-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/
-----------------------------------------------------------
(Updated 9月 9, 2016, 10:21 a.m.)
Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
Bugs: AMBARI-18337
https://issues.apache.org/jira/browse/AMBARI-18337
Repository: ambari
Description
-------
With Python 2.6, ` {"A", "B"} ` syntax isn't allowed.
Ref. https://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
```
As of Python 2.7, non-empty sets (not frozensets) can be created by placing a
comma-separated list of elements within braces, for example: {'jack',
'sjoerd'}, in addition to the set constructor.
```
Error
```
Traceback (most recent call last):
File "unitTests.py", line 129, in stack_test_executor
modules]
File "/usr/lib64/python2.6/unittest.py", line 575, in loadTestsFromName
module = __import__('.'.join(parts_copy))
File
"/tmp/ambari/ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py",
li
ne 646
self.assertFalse({'HAWQMASTER', 'HAWQSTANDBY'}.issubset(hostComponents))
^
SyntaxError: invalid syntax
```
Diffs
-----
ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
71c109f
Diff: https://reviews.apache.org/r/51754/diff/
Testing
-------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827665/AMBARI-18337.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
