----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51713/#review148340 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Sept. 9, 2016, 9:49 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51713/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 9:49 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sumit Mohanty. > > > Bugs: AMBARI-18335 > https://issues.apache.org/jira/browse/AMBARI-18335 > > > Repository: ambari > > > Description > ------- > > Steps to repro: > - Install Ambari 2.2.2 > - Install HDP-2.4.x cluster with Atlas > - Stop Atlas > - Upgrade Ambari to 2.4 > - Delete Atlas service > - Upgrade the cluster to HDP-2.5.x cluster > - Add Atlas service. > > *Below config properties are missing from atlas-applicataion.properties file > for Atlas, Storm, Falcon, Hive services.* > ``` > atlas.jaas.KafkaClient.option.keyTab = > /etc/security/keytabs/atlas.service.keytab > atlas.jaas.KafkaClient.option.principal = atlas/_h...@example.com > ``` > > From HDP 2.4 to 2.5, the kerberos.json file for Atlas changed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java > 84a9111 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java > 39ebdaf > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptor.java > 3cdd9908 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java > 484f65c > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java > 7ce1c9f > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java > 0156e4a > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java > 72dbcfe > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json > d569447 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > ad9fc97 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > 27f2010 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > 4df5fef > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > b8c51f5 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json > 501bcd3 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > 0b6f762 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > 49e9d87 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java > f551b42 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java > b74f417 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java > 6017fae > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java > 9463749 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java > 874da31 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java > c10d106 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java > 5c249e2 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java > e1af515 > > Diff: https://reviews.apache.org/r/51713/diff/ > > > Testing > ------- > > unit tests, manually upgrades > > # Local test results: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:20:19.796s > [INFO] Finished at: Fri Sep 09 09:29:44 EDT 2016 > [INFO] Final Memory: 62M/1882M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >