----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51761/#review148347 -----------------------------------------------------------
Ship it! Ship It! - Di Li On Sept. 9, 2016, 4:59 p.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51761/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 4:59 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jayush Luniya, and > Nate Cole. > > > Bugs: AMBARI-18050 > https://issues.apache.org/jira/browse/AMBARI-18050 > > > Repository: ambari > > > Description > ------- > > Currently each pre-req check must add an entry in the CheckDescription enum. > This limits the ability for third party stacks and extensions to provide > their own pre-req checks. > > The CheckDescription enum should be rewritten as a class and each pre-req > check class should create an instance of it. This will allow stacks and > extensions to include their own pre-req checks in separate jar files without > requiring changes to ambari-server java code. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > aa8e20c > > Diff: https://reviews.apache.org/r/51761/diff/ > > > Testing > ------- > > mvn clean test > -Dtest=AbstractCheckDescriptorTest,UpgradeCheckOrderTest,CheckHelperTest > Ran 267 tests in 8.183s > Total run:1124 > Total errors:0 > Total failures:0 > > > Thanks, > > Tim Thorpe > >
