----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51744/#review148372 -----------------------------------------------------------
ambari-web/app/mappers/stack_service_mapper.js (line 122) <https://reviews.apache.org/r/51744/#comment215830> Since the logic here is that if this variable is true, that means this service is either disabled or it's installed, using the name "isDisabled" will mask partial fact. In another way to sayit, people may be confused about why a service is "disabled" when it's just acctually installed. So maybe call it something like "installedOrDisabled"? - Zhe (Joe) Wang On Sept. 8, 2016, 8:09 p.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51744/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 8:09 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18346 > https://issues.apache.org/jira/browse/AMBARI-18346 > > > Repository: ambari > > > Description > ------- > > Perform a UI hack to force selection of SmartSense for HDP stacks (the user > cannot deselect). > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step4_controller.js 04e6784 > ambari-web/app/mappers/stack_service_mapper.js c800e83 > ambari-web/app/models/stack_service.js 9cf9d49 > ambari-web/app/templates/wizard/step4.hbs c62d369 > > Diff: https://reviews.apache.org/r/51744/diff/ > > > Testing > ------- > > Verified manually. > Ambari-web unit test pass. > 29244 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
