-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51772/#review148398
-----------------------------------------------------------


Ship it!




Ship It!

- Zhe (Joe) Wang


On Sept. 10, 2016, 5:06 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51772/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2016, 5:06 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Oleg Nechiporenko, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18353
>     https://issues.apache.org/jira/browse/AMBARI-18353
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This seems to happen when using set function of Ember data record right after 
> loading the model type by using loadMany function. As a fix, patch waits for 
> the model record to be loaded before attempting to set any property on it.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mappers/service_mapper.js 9c21789 
>   ambari-web/app/models/service.js c648e93 
> 
> Diff: https://reviews.apache.org/r/51772/diff/
> 
> 
> Testing
> -------
> 
> Verified that the patch does not introduce any regression
> Verified that the patch passes all unit tests:
> 
>   29244 tests complete (32 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to