-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51801/
-----------------------------------------------------------

(Updated Sept. 12, 2016, 1:01 p.m.)


Review request for Ambari, Oliver Szabo, Sumit Mohanty, Sebastian Toader, and 
Yusaku Sako.


Bugs: AMBARI-18359
    https://issues.apache.org/jira/browse/AMBARI-18359


Repository: ambari


Description
-------

Some LDAP tests fail to run with forkCount:>1, reuseForks:false. This blocks 
increasing forkCount to speed up the unit tests.


Diffs
-----

  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDNWithSpaceTest.java
 1a18ff2 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
 c0086d6 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 779b0a2 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticatorTest.java
 1716c97 

Diff: https://reviews.apache.org/r/51801/diff/


Testing
-------

* Added forkCount with various values (1, 2, 4, 8, 16) to 
`maven-surefire-plugin` configuration in `ambari-server/pom.xml`, eg.:
```
          <forkCount>4</forkCount>
          <reuseForks>false</reuseForks>
```
 * Ran `mvn -f ambari-server/pom.xml test -DskipPythonTests -Drat.skip 
-Dtest='*Ldap*Test'`
 * Verified test failures/errors that occur without the patch are resolved


Thanks,

Attila Doroszlai

Reply via email to