----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51811/ -----------------------------------------------------------
Review request for Ambari, Jayush Luniya, Laszlo Puskas, Oliver Szabo, and Sebastian Toader. Bugs: AMBARI-18361 https://issues.apache.org/jira/browse/AMBARI-18361 Repository: ambari Description ------- Fix: 1. Upgrade to maven-compiler-plugin from 3.0 (because https://issues.apache.org/jira/browse/MCOMPILER-187 was only fixed in 3.1+) to 3.2 (because it is already used by ambari-logsearch and ambari-metrics) 2. Set useIncrementalCompilation flag to false (defaults to true) to work around https://issues.apache.org/jira/browse/MCOMPILER-209 Diffs ----- ambari-server/pom.xml 45d3ce4 Diff: https://reviews.apache.org/r/51811/diff/ Testing ------- 1. Verify Maven reports "Nothing to compile - all classes are up to date" if no class was changed. ``` mvn -pl ambari-server compile mvn -pl ambari-server compile ``` 2. Verify Maven only reports compilation of 3 source files after 3 source files updated. ``` mvn -pl ambari-server compile find ambari-server/src/main/java -type f | head -3 | xargs touch mvn -pl ambari-server compile ``` 3. Verify Maven compiles all Java sources after removing class files. ``` mvn -pl ambari-server compile find ambari-server -name '*.class' | xargs rm mvn -pl ambari-server compile ``` Thanks, Attila Doroszlai