-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51818/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-18366
https://issues.apache.org/jira/browse/AMBARI-18366
Repository: ambari
Description
-------
When attempting to add a custom {{storm-site}} property which is a YAML map of
maps, the {{storm.yaml}} file being generated is incorrectly escaping the map.
{code:title="Expected YAML"}
nimbus.impersonation.acl:
storm:
hosts:
[c6401.ambari.apache.org, c6402.ambari.apache.org]
groups:
[hadoop, foo]
{code}
{code:title="Actual YAML"}
nimbus.impersonation.acl: 'storm:
hosts:
[c6401.ambari.apache.org, c6402.ambari.apache.org]
groups:
[hadoop, foo]'
{code}
- We should not be escaping YAML maps
- YAML maps must being on a newline with no leading whitespace
Diffs
-----
ambari-common/src/main/python/ambari_commons/yaml_utils.py bb05c8a
ambari-server/src/test/python/TestYAMLUtils.py bdbb11f
Diff: https://reviews.apache.org/r/51818/diff/
Testing
-------
----------------------------------------------------------------------
Total run:1125
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
