-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51238/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 9:31 a.m.)


Review request for Ambari, Jayush Luniya, Nate Cole, Sumit Mohanty, and 
Sebastian Toader.


Changes
-------

Minor formatting fixes


Bugs: AMBARI-15538
    https://issues.apache.org/jira/browse/AMBARI-15538


Repository: ambari


Description
-------

Implementation contains the following things:
- On startup, add-on service repos are loaded into the stack model
- On startup, add-on service repos are merged into the VDF's downloaded by 
LatestRepoCallable
- On startup, if the is an existing cluster, it's repository version entity is 
potentially updated with new add-on service repos.
- Repository definitions contain two new optional fields: service_name and 
service_version. (null for stack repositories) 
- Small changes on the Mictrosoft-R mpack (supoorts HDP-2.4 and 2.5)
- New unit tests


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 7403dba 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1d82928 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 bae4ab6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 02fc2ec 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
bc94104 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
3acc617 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
1fee589 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 7bcd08b 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
811113a 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
14ff9de 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 d26b834 
  ambari-server/src/main/resources/version_definition.xsd bd49028 
  ambari-server/src/test/java/org/apache/ambari/server/stack/RepoUtilTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
 1d73ff3 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
 PRE-CREATION 
  
ambari-server/src/test/resources/common-services/ADDON/1.0/configuration/addon-env.xml
 PRE-CREATION 
  ambari-server/src/test/resources/common-services/ADDON/1.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest_initialRepos.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_common_services/HDP/0.2/services/ADDON/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_common_services/HDP/0.2/services/ADDON/repos/repoinfo.xml
 PRE-CREATION 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/configuration/microsoft-r-env.xml
 PRE-CREATION 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py
 61ea96b 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51238/diff/


Testing
-------

- Manually tested
- Wrote new unit tests
- All unit tests passed except two which were failing in CI builds as well.


Thanks,

Balázs Bence Sári

Reply via email to