----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51892/#review149054 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Sept. 15, 2016, 8:31 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51892/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 8:31 a.m.) > > > Review request for Ambari, Daniel Gergely, Jonathan Hurley, Myroslav > Papirkovskyy, Nate Cole, and Sebastian Toader. > > > Bugs: AMBARI-18367 > https://issues.apache.org/jira/browse/AMBARI-18367 > > > Repository: ambari > > > Description > ------- > > Create a Spring authentication filter to encapsulate the various Ambari > authentication methods since the Spring filter chain allows for a single > authentication filter and Ambari needs to allow for multiple, optional, > authentication filters to handle one of (but not limited to) the following > authentication methods: > > - Basic Auth > - SSO (JWT) > - Kerberos token > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > deac313 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > bd34c25 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilter.java > 0a312f3 > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariDelegatingAuthenticationFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilter.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > 2f676b4 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/AuthenticationJwtUserNotFoundException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilter.java > 760621e > ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml e1697e2 > > ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilterTest.java > 0f2b104 > > ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariDelegatingAuthenticationFilterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariJWTAuthenticationFilterTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > 1d71fe6 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilterTest.java > b08d1ac > > Diff: https://reviews.apache.org/r/51892/diff/ > > > Testing > ------- > > Manually tested > > #Local test results: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:40:31.332s > [INFO] Finished at: Wed Sep 14 10:18:07 EDT 2016 > [INFO] Final Memory: 67M/693M > [INFO] > ------------------------------------------------------------------------ > > > # Jenkins test results: > > > {color:green}+1 overall{color}. Here are the results of testing the latest > attachment > > http://issues.apache.org/jira/secure/attachment/12828479/AMBARI-18367_trunk_01.patch > against trunk revision . > > {color:green}+1 @author{color}. The patch does not contain any @author > tags. > > {color:green}+1 tests included{color}. The patch appears to include 5 > new or modified test files. > > {color:green}+1 javac{color}. The applied patch does not increase the > total number of javac compiler warnings. > > {color:green}+1 release audit{color}. The applied patch does not > increase the total number of release audit warnings. > > {color:green}+1 core tests{color}. The patch passed unit tests in > ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/8676//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/8676//console > > > Thanks, > > Robert Levas > >
