-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51914/
-----------------------------------------------------------

(Updated Sept. 15, 2016, 7:36 p.m.)


Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, and 
Sebastian Toader.


Changes
-------

Removed unnecessary condition according to Laszlo's review


Bugs: AMBARI-18401
    https://issues.apache.org/jira/browse/AMBARI-18401


Repository: ambari


Description
-------

* Implement the Surefire approach for filtering unit tests to be run for Python.
 * Keep backward-compatibility for `custom.tests` flag and default test mask


Diffs (updated)
-----

  ambari-server/pom.xml 323ce22 
  ambari-server/src/test/python/unitTests.py 037b6a5 

Diff: https://reviews.apache.org/r/51914/diff/


Testing
-------

```bash
git apply --include ambari-server/src/test/python/unitTests.py 
AMBARI-18401_20160915_v1.patch

mvn -pl ambari-server test -DskipSurefireTests -Drat.skip
# -> verify all Python unit tests were run (1126 as of now)

mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dcustom.tests
# -> verify no Python unit tests were run

mv -iv ambari-server/src/test/python/{,_}TestStackAdvisor.py
mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dcustom.tests
# -> verify only TestStackAdvisor was run (2 tests as of now)

mv -iv ambari-server/src/test/python/{_,}TestStackAdvisor.py
git apply --include ambari-server/pom.xml AMBARI-18401_20160915_v1.patch
mvn -pl ambari-server test -DskipSurefireTests -Drat.skip
# -> verify all Python unit tests were run

mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dcustom.tests
# -> verify no Python unit tests were run

mv -iv ambari-server/src/test/python/{,_}TestStackAdvisor.py
mvn -pl ambari-server test -DskipSurefireTests -Drat.skip -Dcustom.tests
# -> verify only TestStackAdvisor was run

mv -iv ambari-server/src/test/python/{_,}TestStackAdvisor.py
mvn -pl ambari-server test -DskipSurefireTests -Drat.skip 
-Dpython.test.mask='TestS*py'
# -> verify only TestServerClassPath...TestStackFeature were run (30 tests in 6 
files as of now)
```


Thanks,

Attila Doroszlai

Reply via email to