----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149175 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py (line 107) <https://reviews.apache.org/r/51906/#comment216711> We should not rely on the availability of NN as only HDFS has NN other DFS implementation don't. I think it's safer to check if ```params.default_fs``` is defined as that tells wether there is a DFS available and how that can be referred to. When testing this please ensure that you test with both webhdfs enables and disabled (see ```params.is_webhdfs_enabled```, dfs.webhdfs.enabled config property) ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py (lines 107 - 116) <https://reviews.apache.org/r/51906/#comment216712> Factor this out into a separate method - Sebastian Toader On Sept. 15, 2016, 1:45 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51906/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 1:45 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, > and Sebastian Toader. > > > Bugs: AMBARI-18349 > https://issues.apache.org/jira/browse/AMBARI-18349 > > > Repository: ambari > > > Description > ------- > > A. Add `role_command_order.json` to make sure name node, node manager, > resource manager are started before running Microsoft R service check > B. Create `/user/RevoShare` on HDFS if necessary when starting services > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py > ba9c8fb > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/role_command_order.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/51906/diff/ > > > Testing > ------- > > A. Role command order > 1. Install Ambari (trunk), add Microsoft R mpack, start Ambari > 2. Create cluster via web UI with HDFS, YARN, ZooKeeper, Microsoft R > 3. Verify name node, node manager, resource manager, data node are started > before Microsoft R service check > 4. Verify stage_id for NAMENODE-START, NODEMANAGER-START, > RESOURCEMANAGER-START are smaller than stage_id for > MICROSOFT_R_SERVICE_CHECK-SERVICE_CHECK: > ``` > select request_id, stage_id, task_id, role, role_command from > host_role_command order by request_id, stage_id, task_id; > ``` > B. RevoShare > 1. Install Ambari (trunk), add Microsoft R mpack, start Ambari > 2. Create cluster via blueprint with HDFS, YARN, ZooKeeper, Microsoft R > 3. Verify `/user/RevoShare` directory exists: `hdfs dfs -ls /user/` > > > Thanks, > > Attila Doroszlai > >
