----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149364 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On Sept. 16, 2016, 10:59 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51894/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2016, 10:59 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Di Li. > > > Bugs: AMBARI-18378 > https://issues.apache.org/jira/browse/AMBARI-18378 > > > Repository: ambari > > > Description > ------- > > This task is for providing an option to clone / copy a view instance. > A new "copy" icon will appear next to a view instance. Clicking on this opens > up the existing view with instance name and display name of the view appended > with _Copy. > This will be useful when creating multiple view instances with mild > configuration differences between them. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js > 20bd25c > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 0aefaba > ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 239e39e > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html > 924885f > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > bc441cd > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js > 117021e > > Diff: https://reviews.apache.org/r/51894/diff/ > > > Testing > ------- > > Manual testing with different types of view instances. > Currently there are no automated tests for ambari-admin. > > > File Attachments > ---------------- > > AMBARI-18378.patch > > https://reviews.apache.org/media/uploaded/files/2016/09/16/cd344c4a-e087-46a3-953a-f8f8ae6f7764__AMBARI-18378.patch > > > Thanks, > > Sangeeta Ravindran > >
