-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52124/#review149853
-----------------------------------------------------------



Approach is good, we just need to remove "hdp".


ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
 (line 83)
<https://reviews.apache.org/r/52124/#comment217575>

    Since this is going to be checked-in, let's make it a big generic and 
remove references to "hdp" from function names and variables.



ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py 
(line 35)
<https://reviews.apache.org/r/52124/#comment217576>

    Can we use stack_root instead?



ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py 
(line 39)
<https://reviews.apache.org/r/52124/#comment217577>

    Rename class to RemoveStack



ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py 
(line 59)
<https://reviews.apache.org/r/52124/#comment217580>

    We should use stack_name variable.



ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py 
(line 80)
<https://reviews.apache.org/r/52124/#comment217581>

    There's a config that defines hdp-select in cluster-env.


- Alejandro Fernandez


On Sept. 21, 2016, 4:05 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52124/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-18435
>     https://issues.apache.org/jira/browse/AMBARI-18435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need a script or hacky solution internally for base-cluster to be able to 
> delete old HDP stacks.
> 
> This does not need to be a full-blown feature with tons of bells and whistles 
> and UI support.
> Instead, it needs to be a simple script that can be ran on all hosts.
> 
> Ideally, it would accept the version of the stack to remove, and perhaps can 
> go into contrib.
> If we want to make it slightly better, than we can figure out how to actually 
> make it a custom command to remove older versions (value is less than the 
> CURRENT version).
> If done this way, we can add checks to make it more robust, bubble up errors 
> to the UI task output, etc.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
>  7bbbd3d 
>   
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
>  bc1c271 
>   
> ambari-server/src/main/resources/custom_actions/scripts/remove_hdp_version.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52124/diff/
> 
> 
> Testing
> -------
> 
> Works on Centos
> Adding unit tests
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to