----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52130/#review149894 -----------------------------------------------------------
Ship it! Ship It! - Zhe (Joe) Wang On Sept. 21, 2016, 7:24 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52130/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 7:24 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-18436 > https://issues.apache.org/jira/browse/AMBARI-18436 > > > Repository: ambari > > > Description > ------- > > When there is an installed service that has no config, it results in JS error > while navigating to > "Customize Services" page > STR: > Install a blueprint provisioned cluster with a custom service that has one > config-type for example: x-site.xml. Keep this site empty with no properties > After cluster installation, try to add Slider service. > Expected Result: User should be able to add Slider service. > Actual Result: While navigating to "Customize Services" page, spinner keeps > showing. JS error noticed in dev console > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step7_controller.js a35ea00 > > Diff: https://reviews.apache.org/r/52130/diff/ > > > Testing > ------- > > Tested the patch manually on a cluster > Verified that all unit tests passes with the patch: > > 29243 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
