----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52128/ -----------------------------------------------------------
(Updated Sept. 21, 2016, 8:25 p.m.) Review request for Ambari and Sumit Mohanty. Changes ------- Added branch-2.5 Bugs: AMBARI-18426 https://issues.apache.org/jira/browse/AMBARI-18426 Repository: ambari Description ------- AMBARI-18426: Active ambari server check required in ambari server JAR Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java f1058b6f0a78f8020f9f4d4878e657240e2c450c ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 0e6e6b1e7950ab02c79095d52b4033554f93b050 Diff: https://reviews.apache.org/r/52128/diff/ Testing ------- ** 1. Manual testing ** Verified that if active.instance is set to false in *ambari.properties*, ambari server fails to start with an error message in the log indicating that it is not designated as the active instance. ** 2. mvn test -DskipPythonTests -Dtest=AmbariServerTest ** Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 4969 licence. [INFO] [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server --- [INFO] skipping execute as per configuraion [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 27.993s [INFO] Finished at: Wed Sep 21 11:53:16 PDT 2016 [INFO] Final Memory: 58M/814M [INFO] ------------------------------------------------------------------------ ** 3. mvn clean install -DskipTests ** [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Ambari Main ....................................... SUCCESS [10.092s] [INFO] Apache Ambari Project POM ......................... SUCCESS [0.040s] [INFO] Ambari Web ........................................ SUCCESS [1:12.087s] [INFO] Ambari Views ...................................... SUCCESS [1.203s] [INFO] Ambari Admin View ................................. SUCCESS [8.408s] [INFO] ambari-metrics .................................... SUCCESS [0.699s] [INFO] Ambari Metrics Common ............................. SUCCESS [3.455s] [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.016s] [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.177s] [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.351s] [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.557s] [INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.971s] [INFO] Ambari Metrics Collector .......................... SUCCESS [10.607s] [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.311s] [INFO] Ambari Metrics Grafana ............................ SUCCESS [1.035s] [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:22.803s] [INFO] Ambari Server ..................................... SUCCESS [3:12.569s] [INFO] Ambari Functional Tests ........................... SUCCESS [2:01.732s] [INFO] Ambari Agent ...................................... SUCCESS [26.336s] [INFO] Ambari Client ..................................... SUCCESS [0.052s] [INFO] Ambari Python Client .............................. SUCCESS [1.094s] [INFO] Ambari Groovy Client .............................. SUCCESS [2.457s] [INFO] Ambari Shell ...................................... SUCCESS [0.049s] [INFO] Ambari Python Shell ............................... SUCCESS [0.732s] [INFO] Ambari Groovy Shell ............................... SUCCESS [0.981s] [INFO] ambari-logsearch .................................. SUCCESS [0.302s] [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.241s] [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.333s] [INFO] Ambari Logsearch Portal ........................... SUCCESS [6.840s] [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [4.536s] [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.131s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 9:22.892s [INFO] Finished at: Wed Sep 21 12:07:21 PDT 2016 [INFO] Final Memory: 297M/1079M [INFO] ------------------------------------------------------------------------ Thanks, Nahappan Somasundaram