> On Sept. 21, 2016, 5:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py,
> >  line 36
> > <https://reviews.apache.org/r/52114/diff/1/?file=1507108#file1507108line36>
> >
> >     Why are we making it always pass?

hey Alejandro. You probably confused "before" and "after" code.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52114/#review149850
-----------------------------------------------------------


On Sept. 21, 2016, 9:11 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52114/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 9:11 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18428
>     https://issues.apache.org/jira/browse/AMBARI-18428
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  32e1510 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  61b3ac0 
> 
> Diff: https://reviews.apache.org/r/52114/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to