-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52155/#review150021
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
 (lines 204 - 207)
<https://reviews.apache.org/r/52155/#comment217829>

    Wouldn't this prevent the method from being executed again?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
 (line 225)
<https://reviews.apache.org/r/52155/#comment217827>

    You're not asking for the "id" column in the SQL - how is it present here?



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
 (lines 228 - 229)
<https://reviews.apache.org/r/52155/#comment217826>

    Why did you remove hte `,number,#` ? I believe it's needed to prevent 
formatting of the number using commas or periods.


- Jonathan Hurley


On Sept. 22, 2016, 7:08 a.m., wang yaoxin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52155/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 7:08 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18441
>     https://issues.apache.org/jira/browse/AMBARI-18441
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ambari upgrade to 2.1.1, if the first time failed , excute ambari-server 
> upgrade again will error duplicate key value violates unique constraint 
> "pk_hostcomponentstate".
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
>  db13612 
> 
> Diff: https://reviews.apache.org/r/52155/diff/
> 
> 
> Testing
> -------
> 
> the unit test is UpgradeCatalog211Test.java: Process finished with exit code 
> 0.
> done !
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Reply via email to