> On Sept. 22, 2016, 7:54 p.m., Robert Levas wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py,
> > lines 119-120
> > <https://reviews.apache.org/r/51724/diff/4/?file=1508078#file1508078line119>
> >
> > These shoud not be hardcoded. The aths to the tools (kinit and klist),
> > the principal name, and the keytab file should be found in the config data.
Hi Robert, lines 119 and 120 are both part of the config_content string which
provides default values for the configuration. These are only used if the
config file doesn't exist:
if os.path.exists(CONFIG_FILE_PATH):
self.config.read(CONFIG_FILE_PATH)
else:
self.config.readfp(StringIO.StringIO(config_content))
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51724/#review150057
-----------------------------------------------------------
On Sept. 22, 2016, 12:44 p.m., Qin Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51724/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 12:44 p.m.)
>
>
> Review request for Ambari, Di Li, Dmytro Sen, and Sid Wagle.
>
>
> Bugs: AMBARI-17898
> https://issues.apache.org/jira/browse/AMBARI-17898
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ()This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to
> authenticate".
>
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari
> Metrics Collector (in AMS distributed mode) web-console will be Kerberos HTTP
> SPNEGO enabled too. But Ambari Metrics Monitor, a client of Ambari Metrics
> Collector, currently does not support Kerberos HTTP SPNEGO authentication.
>
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server:
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-assembly/pom.xml d73a0af
> ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini
> e98c65c
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
> 3ca3a31
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py
> 050af16
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/faked_kerberos.py
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
> 51f541f
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
> 6934924
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
> 3823912
>
> Diff: https://reviews.apache.org/r/51724/diff/
>
>
> Testing
> -------
>
> 1. passed existing unittest cases.
> 2. manually tested with HDP-2.5.0.0/trunk
> 1) Non http spnego enabled clusters
> 2) http spnego enabled cluster - tested the trunk's monitor code against a
> http spnego enabled cluster
> http spnego enabled cluster is currently broken in trunk: the
> distributed metrics collector's http server currently will not started with
> http spnego enabled. so I had to manually test the trunk's monitor code with
> http spnego enabled collector on a branch2.4 cluster. Need to mention that
> the testing should be valid because the code change area is monitor code and
> the trunk and branch2.4's collectors are same.
>
>
> Thanks,
>
> Qin Liu
>
>
