-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51647/#review150166
-----------------------------------------------------------




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
 (line 32)
<https://reviews.apache.org/r/51647/#comment218037>

    Check use of this property else remove.



contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
 (line 157)
<https://reviews.apache.org/r/51647/#comment218036>

    Please verify the use of this and following property and remove is not 
required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 50)
<https://reviews.apache.org/r/51647/#comment218034>

    Looks like this property is not used, please verify and remove if not 
required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 58)
<https://reviews.apache.org/r/51647/#comment218035>

    Looks like this function is not used is the above property is not used, 
please verify and remove if not required.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 (line 142)
<https://reviews.apache.org/r/51647/#comment218033>

    Please check if this and the above computed properties are used. Else 
please remove the same.



contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
(line 246)
<https://reviews.apache.org/r/51647/#comment218032>

    Just a comment, would be better to folow one standard for variables. Cammel 
case is what normally used.



contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js (line 274)
<https://reviews.apache.org/r/51647/#comment218038>

    PLease check where this action is called from.



contrib/views/capacity-scheduler/src/main/resources/ui/bower.json (line 16)
<https://reviews.apache.org/r/51647/#comment218031>

    Package versiosn must be fixed.


- Sreenath Somarajapuram


On Sept. 6, 2016, 9:26 a.m., Akhil PB wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51647/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18313
>     https://issues.apache.org/jira/browse/AMBARI-18313
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> XML diff tool to show changes made.
> View capacity scheduler XML.
> Queue capacity chart - chart showing capacities of queue using sunburst chart.
> Bug fixes.
> 
> 
> Diffs
> -----
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/index.html 
> 2cdfe39 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/stylesheets/diffview.css
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> 8dd7108 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  7776452 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js
>  f8978c2 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  64a28343 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  107b377 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  2690c40 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  c079079 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  447cae0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  7c62ef0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  6a6717a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  40e3e24 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> 0f68a10 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> fd996ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  bd875ba 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 2c9609f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  14625c1 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  5a54d85 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  922e27e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs
>  873fb6f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  d594c7e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  608758f 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  809c1c0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  0c70ee5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  66ef1ad 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  fb34d51 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  33540e9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  a7ae9b0 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f 
> 
> Diff: https://reviews.apache.org/r/51647/diff/
> 
> 
> Testing
> -------
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Reply via email to