-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52260/
-----------------------------------------------------------

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-18459
    https://issues.apache.org/jira/browse/AMBARI-18459


Repository: ambari


Description
-------

This is to provide basic error message print outs when a user defines a 
bulkcommand section in a service's metainfo.xml where he unknowingly addes a 
component that doesn't exist. For example, adding a component called "master" 
to HBASE_REGIONSERVER's bulkcommand section should see the server prints out an 
error message.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
a77a22f 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
93eeb7e 

Diff: https://reviews.apache.org/r/52260/diff/


Testing
-------

existing unit test.
patched a trunk cluster with the change, 
1. modified HBase metainfo.xml at the common service level and see the error 
messages showed up for all HDP stacks.
2. modified hbase metainfo.xml at both common service and HDP 2.5 level (2.5 
level has the correct bulkcommand section), see the error messages for HDP 
2.0.6 up to HDP 2.4, no error in HDP 2.5 (as it has the correct bulkcommand 
section)


Thanks,

Di Li

Reply via email to