> On Sept. 26, 2016, 6:34 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java,
> >  line 103
> > <https://reviews.apache.org/r/52266/diff/1/?file=1510202#file1510202line103>
> >
> >     This should be LOG.error in my opinion

Actually, a standalone Ambari Server for views will not have any cluster 
versions, so warn is ok.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52266/#review150434
-----------------------------------------------------------


On Sept. 26, 2016, 6:23 p.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52266/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-18430
>     https://issues.apache.org/jira/browse/AMBARI-18430
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problems during cluster install can result in clusters without a cluster 
> version. UpdateActiveRepoVersionOnStartup.process() threw NPE in these case. 
> NPE check is added
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  1413c66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
>  9c54a88 
> 
> Diff: https://reviews.apache.org/r/52266/diff/
> 
> 
> Testing
> -------
> 
> - Added a new unit test
> - All unit tests in ambari-server passed
> - Did manual testing to verify (removed cluster version from the DB and 
> restarted the server)
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to