----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52282/#review150546 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Sept. 26, 2016, 5:53 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52282/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 5:53 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-18470 > https://issues.apache.org/jira/browse/AMBARI-18470 > > > Repository: ambari > > > Description > ------- > > RU/EU PreCheck for running ServiceChecks after config changes is incorrect. > > Example: > ``` > Last Service Check should be more recent than the last configuration change > for the given service > Reason: The following service configurations have been updated and their > Service Checks should be run again: HIVE, SPARK, RANGER, YARN > Failed on: HIVE,SPARK,RANGER,YARN > ``` > > > Root Cause: > When the database has more than 1000 Service Checks, the EU/RU PreCheck for > ensuring that a Service Check has ran after any config changes to a service > is incorrect because it takes the first 1000 HostRoleCommand records as > opposed to the last page of 1000. > > This is because ServiceCheckValidityCheck.java doesn't impose an ordering > when creating a pagination request from TaskResourceProvider.java > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2bc22c9 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java > 8d72b96 > > Diff: https://reviews.apache.org/r/52282/diff/ > > > Testing > ------- > > Verified using database dump and ran unit tests in > ServiceCheckValidityCheckTest.java > > > Thanks, > > Alejandro Fernandez > >
