-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52298/#review150572
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 27, 2016, 10:05 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52298/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18471
>     https://issues.apache.org/jira/browse/AMBARI-18471
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix the most obvious points of the main jira. 
> 1\. Refactor this code to have individual functions for components.  
> 2\. Remove conditions for xmlConfigs, where they are not needed
> 
> The other part of the jira requires more discussion, it probably will be
> easier to do once we have a cleaner look on the code and shrink the scope of
> the issue.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  4d42861 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  a3a3a06 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 643f946 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> dc11ba9 
>   ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py abfe756 
> 
> Diff: https://reviews.apache.org/r/52298/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to