> On Sept. 26, 2016, 9:33 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java,
> >  line 97
> > <https://reviews.apache.org/r/52266/diff/1/?file=1510202#file1510202line97>
> >
> >     When I tried this on my cluster that was installed failed by making a 
> > jar, it did not come out of the bad state. Just want to make sure the 
> > manual testing on this was good.
> 
> Balázs Bence Sári wrote:
>     I tested it by installing the cluster, then deleting the cluster version 
> from the DB, then restarting the server. The server was able to restart. 
>     I don't know what other problems missing cluster versions can cause, but 
> the startup issue is fixed by this patch. Could you describe what errors you 
> saw after applying the patch?

Unfortunately, I already duid a reset so do not have exact failure but on the 
repro, could you simulate a failure via stack script? That would be a exact 
repro.

I have attached logs to the external Jira: AMBARI-18467. The attached link on 
the RB is incorrect.
If you search for UpdateActiveRepoVersionOnStartup, second to last occurence 
and look at the restart after that, it might provide some clues.


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52266/#review150459
-----------------------------------------------------------


On Sept. 26, 2016, 6:23 p.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52266/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-18430
>     https://issues.apache.org/jira/browse/AMBARI-18430
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problems during cluster install can result in clusters without a cluster 
> version. UpdateActiveRepoVersionOnStartup.process() threw NPE in these case. 
> NPE check is added
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
>  1413c66 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
>  9c54a88 
> 
> Diff: https://reviews.apache.org/r/52266/diff/
> 
> 
> Testing
> -------
> 
> - Added a new unit test
> - All unit tests in ambari-server passed
> - Did manual testing to verify (removed cluster version from the DB and 
> restarted the server)
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to