> On Sept. 27, 2016, 2:13 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 825-828 > > <https://reviews.apache.org/r/52304/diff/1/?file=1511022#file1511022line825> > > > > Is this necessarily true? Suppose that there's a repository for a patch > > and the available services actually includes every single service. > > > > Is the scope still partial?
The if-block containing this checks if it's (not) a STANDARD repo, that means it's for a patch. We have to trust that the VDF is going to be correct for what it contains. If it says it's a PATCH but defines all services, then so be it. One would hope that if all the services are in it, the VDF would be a STANDARD RU/EU. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52304/#review150584 ----------------------------------------------------------- On Sept. 27, 2016, 12:54 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52304/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 12:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-18473 > https://issues.apache.org/jira/browse/AMBARI-18473 > > > Repository: ambari > > > Description > ------- > > This is another addition to "getting things back" for PU. > > Added a unit test, and other tests already cover the Scope and Services > elements. > > Did NOT do a full refactor for the new abstract class; that is a separate > cleanup task. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 15caa69 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java > 7705c7d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > a07d0e6 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 2f616e7 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 80bb26c > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java > 207b4c7 > > Diff: https://reviews.apache.org/r/52304/diff/ > > > Testing > ------- > > Manual. Automated: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:43.185s > [INFO] Finished at: Tue Sep 27 11:42:58 EDT 2016 > [INFO] Final Memory: 44M/761M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
