-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51702/#review150758
-----------------------------------------------------------


Ship it!




Ship It!

- Zhe (Joe) Wang


On Sept. 27, 2016, 11:42 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51702/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 11:42 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Zhe (Joe) Wang, Richard Zang, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-18308
>     https://issues.apache.org/jira/browse/AMBARI-18308
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Go to any of the service config screen ( for e.x Hive ) and add and remove 
> multiple properties one after another (without using bulk add).
> This results in javascript memory leak.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 
> ad1a2f9 
>   
> ambari-web/test/views/common/configs/service_configs_by_category_view_test.js 
> 7b6c451 
> 
> Diff: https://reviews.apache.org/r/51702/diff/
> 
> 
> Testing
> -------
> 
> tested the patch manually to resolve the issue.
> verified that all ambari-web unit tests passes with the patch:
> 
>   29244 tests complete (29 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to