----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52396/ -----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-18490 https://issues.apache.org/jira/browse/AMBARI-18490 Repository: ambari Description ------- If you cancel the Set Rack dialog without entering any value, an error appears at the bottom of the dialog instead of the dialog being dismissed. Only when you click the second time does the dialog disappear. This happens because the validate function gets called during cancel and because no value was entered for rack id, the rack id is null and the validation code flags the error. Fix is to initialize the rack id to an empty string so that validation does not flag an error even during Cancel. Diffs ----- ambari-web/app/utils/hosts.js e4a437c Diff: https://reviews.apache.org/r/52396/diff/ Testing ------- Manual testing. mvn clean test 30366 tests complete (45 seconds) 151 tests pending There are existing test cases for validation of rackID. Thanks, Sangeeta Ravindran