-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151068
-----------------------------------------------------------




contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
 (line 107)
<https://reviews.apache.org/r/52430/#comment219180>

    what can the file name be? is it the same as the query id ?


- Di Li


On Sept. 30, 2016, 4:42 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 4:42 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18496
>     https://issues.apache.org/jira/browse/AMBARI-18496
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> An option to download the saved query can be included.
> 
> 
> Diffs
> -----
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
>  ccc4512 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
>  cbf6b42 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  f7f7706 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
>  9ea19c6 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
> cbf6b42 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> f7f7706 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
>  d55858f 
> 
> Diff: https://reviews.apache.org/r/52430/diff/
> 
> 
> Testing
> -------
> 
> Ran mvn test
> 
> Added 1 new test case
> 
> 
> File Attachments
> ----------------
> 
> screenshot2.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Reply via email to