> On Вер. 30, 2016, 5:28 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/utils.py, line 158
> > <https://reviews.apache.org/r/52411/diff/3/?file=1516838#file1516838line158>
> >
> >     pids isn't changing inside the while block, can move the check 
> > len(pids) > 0 before it.

In loop we are checking if process is alive, using pid.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52411/#review151042
-----------------------------------------------------------


On Вер. 30, 2016, 9:35 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52411/
> -----------------------------------------------------------
> 
> (Updated Вер. 30, 2016, 9:35 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18501
>     https://issues.apache.org/jira/browse/AMBARI-18501
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If due to some error, ambari-server JAR exits with -1, we still display 
> “Ambari Server ‘start’ completed successfully”
> In AmbariServer.java::main(), if an exception occurs, the program exits with 
> -1. Howerver, the caller ambari-server.py::main() displays the status message 
> as "Ambari Server 'start' completed successfully".
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/utils.py 012d428 
>   ambari-server/src/main/python/ambari_server_main.py 57ec58d 
>   ambari-server/src/test/python/TestUtils.py db94d92 
> 
> Diff: https://reviews.apache.org/r/52411/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to