-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li.
Bugs: AMBARI-18476
https://issues.apache.org/jira/browse/AMBARI-18476
Repository: ambari
Description
-------
AMBARI-12263 adds support for PAM as authentication mechanism for accessing
Ambari UI/REST. The changes in this review request cover the corresponding
changes in the amabri-admin code.
Since a new column groupt_type has been added for groups, the UI will display
labels for group type and enable/disable group delete/add member functionality
based on the group_type instead of the ldap_group flag.
Patch includes similar changes for users. The user_type will be used to
determine if the user can be deleted or if the user's password can be changed.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
2e7830b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js
1f86393
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js
af22d7f
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js
660306c
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js
da63c6d
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html
8271432
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html
b359ede
ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html
e576b28
Diff: https://reviews.apache.org/r/52455/diff/
Testing
-------
Manual testing.
Tests in ambari admin project ran clean.
PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
Thanks,
Sangeeta Ravindran