----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52485/#review151188 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java (line 71) <https://reviews.apache.org/r/52485/#comment219465> No XmlElement? - Jayush Luniya On Oct. 3, 2016, 3:20 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52485/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 3:20 p.m.) > > > Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako. > > > Bugs: AMBARI-18516 > https://issues.apache.org/jira/browse/AMBARI-18516 > > > Repository: ambari > > > Description > ------- > > When a service is added to a stack, it should be identified as: > default/regular - service is optional on the cluster, UI usually shows it as > tech-preview - service may be deployed, UI will not auto-select these > services and mark them as TechPreview > mandatory - service need to be deployed and all deployment should fail is the > service is not selected during deployment > Lets create a proposal of what changes are needed in the services' > metainfo.xml? Note that a service can change its attribute between stack > versions - e.g. move from "tech-preview" to "mandatory". > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 5865e20 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 16713dd > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > 34e65c3 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > b0d81c3 > ambari-server/src/main/resources/properties.json eb27878 > > Diff: https://reviews.apache.org/r/52485/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
