-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52496/
-----------------------------------------------------------
(Updated Oct. 3, 2016, 10:56 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-18518
https://issues.apache.org/jira/browse/AMBARI-18518
Repository: ambari
Description
-------
Currently, an exception is constantly being thrown in sink logs.
2016-10-03 21:01:06,537 WARN availability.MetricCollectorHAHelper
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(91)) - Unable to
connect to zookeeper.
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException$ConnectionLossException:
KeeperErrorCode = ConnectionLoss for /ambari-metrics-cluster
at
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:99)
at
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:51)
at
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1045)
at
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1073)
at
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:78)
at
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:344)
at
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:216)
at
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:345)
at
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)
After the change
2016-10-03 21:08:31,494 INFO availability.MetricCollectorHAHelper
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(80)) -
/ambari-metrics-cluster znode does not exist. Skipping requesting live
instances from zookeeper
Diffs
-----
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
4d0ec14
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
ac1f52d
Diff: https://reviews.apache.org/r/52496/diff/
Testing (updated)
-------
Manually tested.
Unit test added.
Thanks,
Aravindan Vijayan
